Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/updated GitHub integration UI #1754

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Fix/updated GitHub integration UI #1754

merged 5 commits into from
Nov 10, 2023

Conversation

badalkhatri0924
Copy link
Contributor

@badalkhatri0924 badalkhatri0924 commented Nov 9, 2023 •
edited
Loading

image

@badalkhatri0924 badalkhatri0924 added the WEB Web app label Nov 9, 2023
@badalkhatri0924 badalkhatri0924 added this to the v0.1.0 milestone Nov 9, 2023
@badalkhatri0924 badalkhatri0924 self-assigned this Nov 9, 2023
@evereq
Copy link
Member

evereq commented Nov 9, 2023

Hm, but what about text of description for each? Is it "Lorem" like in screenshot!? :)

@badalkhatri0924 badalkhatri0924 marked this pull request as draft November 9, 2023 17:28
@evereq
Copy link
Member

evereq commented Nov 9, 2023

Also, text is "hardcoded" in the components code...

@evereq
Copy link
Member

evereq commented Nov 9, 2023

@badalkhatri0924 see also https://github.com/ever-co/ever-teams/actions/runs/6815310943/job/18534123124#step:7:50

@badalkhatri0924 badalkhatri0924 marked this pull request as ready for review November 10, 2023 05:14
@badalkhatri0924
Copy link
Contributor Author

@evereq fixed all.

@evereq evereq merged commit ba5b72f into develop Nov 10, 2023
6 of 7 checks passed
@evereq evereq deleted the fix/updated-github-integration-ui branch November 10, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evereq evereq Awaiting requested review from evereq

Assignees

@badalkhatri0924 badalkhatri0924

Labels
WEB Web app
Projects
Ever Teams Platform
Status: ✅ Done
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@badalkhatri0924 @evereq